Do not emit touchCancel at scroll if responderIgnoreScroll is disabled#53955
Closed
zeyap wants to merge 2 commits into
Closed
Do not emit touchCancel at scroll if responderIgnoreScroll is disabled#53955zeyap wants to merge 2 commits into
zeyap wants to merge 2 commits into
Conversation
Summary: ## Changelog: [Android] [Changed] - Add responderIgnoreScroll prop on ScrollView When it's set to true (default), emit touchcancel from native Android ScrollView, instead of letting Responder System terminate responder at scroll. When false, `onTouchCancel` on ScrollView children will not be invoked, but `onTouchEnd` will be invoked (if touch starts on it) - which aligns with iOS. Allow opting in this new behavior at component level because (1) touchCancel is meaningful especially on android, and dev may be using onTouchCancel handler, if we enable this everywhere the handler is broken, (2) there's likely some issue in responder system when transferring js responder Differential Revision: D82761242
Summary: ## Changelog: [Android] [Changed] - Do not emit touchCancel at scroll if responderIgnoreScroll is disabled Last change react#53951 added `responderIgnoreScroll` prop to ScrollView on android; here is native implementation Differential Revision: D82675049
meta-cla
Bot
added
the
CLA Signed
Contributor
facebook-github-bot
added
fb-exported
meta-exported
p: Facebook
Collaborator
|
Collaborator
|
This PR is stale because it has been open for 180 days with no activity. It will be closed in 7 days unless you comment on it or remove the "Stale" label. |
react-native-bot
added
the
Stale
Collaborator
|
This PR was closed because it has been stalled for 7 days with no activity. |
react-native-bot
removed
the
Stale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog:
[Android] [Changed] - Do not emit touchCancel at scroll if responderIgnoreScroll is disabled
Last change #53951 added
responderIgnoreScrollprop to ScrollView on android; here is native implementationDifferential Revision: D82675049